Syrius: bug fusing widget resets address field

CryptoFish · January 19, 2023, 10:00am

Problem

There is still an issue where if you enter the beneficiary address, entering the amount resets the beneficiary addy to the original one, and you need to change it again.

Cause

A widget’s state is stored in a State object, separating the widget’s state from its appearance. The state consists of values that can change, like a slider’s current value or whether a checkbox is checked. When the widget’s state changes, the state object calls setState(), telling the framework to redraw the widget.

Solution

Comment out the setState(() {}); prevents the redraw of the widget.

github.com

zenon-network/syrius/blob/9a394eb7a0f21306e90a2dea86f33276d58f874f/lib/widgets/modular_widgets/plasma_widgets/plasma_options/plasma_options.dart#L191


      
          crossAxisAlignment: CrossAxisAlignment.stretch,
          children: [
            SizedBox(
              height: 87.0,
              child: Form(
                key: _qsrAmountKey,
                autovalidateMode: AutovalidateMode.onUserInteraction,
                child: InputField(
                  enabled: _maxQsrAmount! > 0,
                  onChanged: (String value) {
                    setState(() {});
                  },
                  inputFormatters:
                      FormatUtils.getPlasmaAmountTextInputFormatters(
                    _qsrAmountController.text,
                  ),
                  controller: _qsrAmountController,
                  validator: (value) => InputValidators.correctValue(
                    value,
                    _maxQsrAmount,
                    kQsrCoin.decimals,

Implementation

https://github.com/KingGorrin/syrius/tree/fix-fusing-addr-reset

0x3639 · January 19, 2023, 10:07am

Ha, funny you raise this issue. I experienced this too last night. It took me a while to figure out what was happening. I eventually figured out I just needed to paste in the address, then the amount, and then could fuse. But it seemed strange.

Glad you raised this issue. It should be fixed b/ for a new user it could be frustrating for them.

aliencoder · January 19, 2023, 11:31am

You can open a PR and I’ll merge it.

0x3639 · January 19, 2023, 5:35pm

I can confirm this was fixed in the latest release on mac. But I found a new issue. Will create a separate post.

ZNNAYIID · January 19, 2023, 5:45pm

I don’t know where to post this, but can we have a toggle for notifications? Or maybe only get important notifications (sent/received txs, plasma generated…) ? I’m getting a notification for copying my address for example.

aliencoder · January 19, 2023, 6:28pm

Yes, but it requires more time for implementation. Disabling notification should definitely be on a task list in the future.

CryptoFish · March 1, 2023, 4:06pm

OP correction.

What?

Under the plasma tab, where if you enter the beneficiary address, entering the amount resets the beneficiary address to the current selected address, and you need to change it again.

Why?

A widget’s state is stored in a State object, separating the widget’s state from its appearance. The state consists of values that can change, like a slider’s current value or whether a checkbox is checked. When the widget’s state changes, the state object calls setState(), telling the framework to redraw the widget.

The setState() is called when the amount changes, causing a redraw of the widget.

The beneficiary address is initialized in the build method. A redraw will initialize and consequently overwrite the beneficiary address to the currently selected address. Effectivly overwriting changes made to beneficiary address everytime the amount changes.

How?

By subscribing to the PlasmaBeneficiaryAddressNotifier in the initState method, will initializes the beneficiary address one time and overwrite it when the selected address changes and not when the widget gets rebuild.

Anything else?

Using Provider.of<>() within the initState method requires listen to be false.

The PlasmaBeneficiaryAddressNotifier ends up with multiple listeners when using an anonymous method which could introduce a memory leak.