Syrius: account statistics max rpc exception

CryptoFish · March 1, 2023, 4:20pm

What?

The account-chain stats widget raises a “JSON-RPC error -32000: count parameter is too big” exception when an account chain reaches a height bigger than 1024 blocks.

Why?

The AccountChainStatsBloc calls the getAccountBlocksByHeight api method, using the total account block count as count argument. The count argument has a maximum allowed value of 1024 as devined in the RpcMaxCountSize variable.

The go-zenon rpc method has the following check.

github.com

zenon-network/go-zenon/blob/c0f931d3cd9844a487ae08ed15f5c52896a9bb44/rpc/api/ledger.go#L126


      
          	if block == nil {
          		return nil, nil
          	}
          
          
	return ledgerAccountBlockToRpc(l.chain, block)
          }
          func (l *LedgerApi) GetAccountBlocksByHeight(address types.Address, height, count uint64) (*AccountBlockList, error) {
          	if height == 0 {
          		return nil, ErrHeightParamIsZero
          	}
          	if count > RpcMaxCountSize {
          		return nil, ErrCountParamTooBig
          	}
          
          
	accountStore := l.chain.GetFrontierAccountStore(address)
          	frontier, err := accountStore.Frontier()
          	if err != nil {
          		l.log.Error("GetAccountBlocksByHeight failed", "reason", err, "method-called", "accountStore.Frontier")
          		return nil, err
          	}
          	if frontier == nil {

How?

The account chain blocks must be retrieved in batches of 1024 blocks until all account blocks are retrieved.

Anything else?

No getAccountBlocksByHeight rpc call will be made when an account chain has no account blocks.

Implementation

https://github.com/KingGorrin/syrius/tree/fix-account-stats-max-rpc

mehowbrainz · September 12, 2023, 7:00pm

mehowbrainz · September 12, 2023, 7:00pm

mehowbrainz · September 12, 2023, 7:01pm