March 13, 2023, 11:52pm
Just wanted to remind everyone of the March target for PR submissions.
@aliencoder @sumamu @DrBlaze_21 we would love to jump on a Discord chat before the deadline to discuss your work and give the community an opportunity to ask questions. We can do them separately.
I’m hoping we can submit the Syrius PRs to:
disable the bridge
setup automatic releases (Github Actions / cicd)
@aliencoder is working on this?
The bug fixes which have been published to the forum can be submitted as seperate PR’s.
More details can be found on the forum under the following posts:
A non-pillar user has to switch the selected address to see projects on another address. While a pillar user sees all projects for all addresses.
An user with 3 addresses
Address 1 has a pillar registration and 3 projects
Address 2 has 1 project
Address 3 has 1 project
When address 1 is selected, the user sees all 5 projects when activating the ‘My projects’ filter tag.
When address 2 or 3 is selected, the user only sees project 1 when activating the ‘My projects’ filter ta…
The account-chain stats widget raises a “JSON-RPC error -32000: count parameter is too big” exception when an account chain reaches a height bigger than 1024 blocks.
The AccountChainStatsBloc calls the getAccountBlocksByHeight api method, using the total account block count as count argument. The count argument has a maximum allowed value of 1024 as devined in the RpcMaxCountSize variable.
The go-zenon rpc method has the following check.
The account chain blocks must be r…
Both the PlasmaBeneficiaryAddressNotifier and SelectedAddressNotifier get initialized with the default address when syrius starts. Selecting the default address for the beneficiary address under the Plasma tab won’t cause a change and subsequently the listeners will not get notified of the selected address.
This problem was less apparent before the Plasma Reset Bug Fix, because the address was always initialized when the Plasma was loaded. However, the problem is still present even witho…
The y axis interval values for the StandardChart sometimes overlaps with the second value.
The y axis uses a default chart title length of 10. The y axis interval value does not match when the total number of tx’s of the day is greater than 10.
Use a non zero-based calculation when determining the y axis interval value.
Calling the Get-It Service Locator unregister method within the main dispose method causes an exception when closing the application.
According to the Get-It package documentation the unregister method is used to unregister an [instance] of an object or a factory/singleton by Type [T] or by name [instanceName]. Not supplying an Type [T] or name causes the exception.
The reset method should be used to fully dispose the Service Locator. The reset method is asynchronous and cannot be…
The realtime statistics are never calculated.
The realtime statistics are calculated on last week account blocks. Account blocks are retrieved by account block height. The momentum height is calculated using the frontier momentum height minus a fixed momentums per week constant of 60480. The calculated momentum height cannot be used to retrieve the last week account blocks and will always return an empty result.
Page through the account blocks until the momen…
Incomplete results are given when filtering Accelerator Z projects without using a search term.
The bug only occures when no search term is used.
When no search term is used, the getAll(pageIndex, pageSize) paging method is used. The paging variables are supplied by the infinite_scroll_bloc.
The infinite_scroll_bloc uses a static pageSize of 10.
Example: the getAll() method returns 10 projects, 6 of which are rejected or completed. The user applies the “Only Acce…
Under the plasma tab, where if you enter the beneficiary address, entering the amount resets the beneficiary address to the current selected address, and you need to change it again.
A widget’s state is stored in a State object, separating the widget’s state from its appearance. The state consists of values that can change, like a slider’s current value or whether a checkbox is checked. When the widget’s state changes, the state object calls setState(), telling the …
I’m open to discuss the work when needed.
I’m definitely considering these as well. My main concern is the amount of testing/review required.
I’ll ask the testers if they have the time to validate these.
@sol_sanctum and @CryptoFish great work on the PRs!
Just been testing them on a Mac and wanted to post feedback, some branches I’m unable to test due to the specific condition required to replicate the issue but if theres test accounts or ways to setup the wallet as required Im happy to test them as well.
Sol-Sanctum/disable_bridge - Much better with the form being removed completely, all works as expected.
KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.
KingGorrin/fix-rt-stats - Looks good, the graph loads both ZNN and QSR stats.
KingGorrin/fix-rt-yaxis - Not sure exactly what was broken but could not spot anything wrong.
KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.
I noticed two bits of visual distortion throughout all the branches
1st The copy/paste/select all popup alignment is messed up:
2nd the delegation stats widget, this only showed when Syrius is in a small window when i resized it it disappeared.
Final point, copy/paste keyboard shortcuts dont work on a Mac, this is also an issue with the current official release, not sure if its Mac specific or on other platforms as well.
copy/paste/select all popup bug was addressed here:
11:25AM - 01 Feb 23 UTC
The right-click menu options should be in a row, not a column.
Syrius uses the default `contextMenuBuilder` for the TextFormField widgets. It controls the default copy/paste/cut/select all buttons for the platform. For example, under the Plasma tab when selecting the beneficiary address text and right clicking it.
The context menu was horizontally orientated, but after using flutter 3.7.0 the buttons are now stacked vertically, showing black at both sides because the context menu is larger than the width of the buttons in it.
Besides the change in the context menu, the selection handles when selecting text are not green anymore.
I could not find a solution to change the orientation of the button items in the context menu, but did manage to style it accordingly by explicitly setting a `contextMenuBuilder` on the `InputField` widget.
The context menu button items are now stacked vertically, using the complete width of the menu.
The `selectionHandleColor` is added to the AppTheme. The property controls the handle color of the selection handles. More info on this can be found at: https://docs.flutter.dev/release/breaking-changes/text-selection-theme
I also noticed it and checked his fix, works well:
Tested on Windows 10:
Sol-Sanctum/disable_bridge [ ]
KingGorrin/fix-fusing-addr-reset [ ]
Thank you for testing .
There’s a fix for that one too, but both the ‘Fix context menu’ and ‘Fix RenderFlex overflow’ still depends on
cicd branch. You can find it here.
11:48AM - 27 Jan 23 UTC
A RenderFlex overflowed exception is thrown in the card_scaffold an
… d pillars_list_widget widgets when the application window is resized to its minimum allowed width/height.
According to this [article ](https://docs.flutter.dev/testing/common-errors) the RenderFlex overflow is one of the most frequently encountered Flutter framework errors and usually occurs when a Column or Row has a child widget that is not constrained in its size.
Contrain the unconstrained child widgets by wrapping them in an Expanded widget.
# Things to know
This PR only solves the widgets currently causing the exception. When Locales get implemented the issue might become apparent in other widgets because of varying string sizes.
I don’t know exactly how you are testing, but seems like you’re using the build based on the
A better way of testing would be to isolate each and individual branch and build it from source. Using the official s y r i u s client as reference.
cicd branch compounds a lot of changes which makes isolating the issue or feature hard.
I used the following procedure for testing my branches that are based on the Zenon_Network\master branch.
GitHub - zenon-network/syrius
git remote add KingGorrin
GitHub - KingGorrin/syrius
git pull KingGorrin
libznn.dll to .\build$OS\runner\Release
test and compare changes with the official client
$branch with one of my branch names posted
macos based on your operating system.
You can copy the missing dll files from the official s y r i u s client. Also make sure you have flutter installed.
Thanks for the links to those extra branches, just tested both and the issues have been resolved.
Iv been testing by checking out each of the feature branches and building a new copy of syrius for each one.