March PR Deadline

[0x3639]

Just wanted to remind everyone of the March target for PR submissions. @aliencoder @sumamu @DrBlaze_21 we would love to jump on a Discord chat before the deadline to discuss your work and give the community an opportunity to ask questions. We can do them separately.

Learn Zenon

[sol_sanctum]

I’m hoping we can submit the Syrius PRs to:

• disable the bridge
• setup automatic releases (Github Actions / cicd)

I think @aliencoder is working on this?

[CryptoFish]

The bug fixes which have been published to the forum can be submitted as seperate PR’s.

More details can be found on the forum under the following posts:

Syrius: AZ my projects filter

What? A non-pillar user has to switch the selected address to see projects on another address. While a pillar user sees all projects for all addresses. Example An user with 3 addresses Address 1 has a pillar registration and 3 projects Address 2 has 1 project Address 3 has 1 project When address 1 is selected, the user sees all 5 projects when activating the ‘My projects’ filter tag. When address 2 or 3 is selected, the user only sees project 1 when activating the ‘My projects’ filter ta…

Syrius: account statistics max rpc exception

What? The account-chain stats widget raises a “JSON-RPC error -32000: count parameter is too big” exception when an account chain reaches a height bigger than 1024 blocks. Why? The AccountChainStatsBloc calls the getAccountBlocksByHeight api method, using the total account block count as count argument. The count argument has a maximum allowed value of 1024 as devined in the RpcMaxCountSize variable. The go-zenon rpc method has the following check. How? The account chain blocks must be r…

Syrius: fusing address select

What? Both the PlasmaBeneficiaryAddressNotifier and SelectedAddressNotifier get initialized with the default address when syrius starts. Selecting the default address for the beneficiary address under the Plasma tab won’t cause a change and subsequently the listeners will not get notified of the selected address. This problem was less apparent before the Plasma Reset Bug Fix, because the address was always initialized when the Plasma was loaded. However, the problem is still present even witho…

Syrius: realtime graph has overlapping y-axis values

What? The y axis interval values for the StandardChart sometimes overlaps with the second value. Why? The y axis uses a default chart title length of 10. The y axis interval value does not match when the total number of tx’s of the day is greater than 10. How? Use a non zero-based calculation when determining the y axis interval value. Implementation

Syrius: main dispose causes exception

What? Calling the Get-It Service Locator unregister method within the main dispose method causes an exception when closing the application. Why? According to the Get-It package documentation the unregister method is used to unregister an [instance] of an object or a factory/singleton by Type [T] or by name [instanceName]. Not supplying an Type [T] or name causes the exception. The reset method should be used to fully dispose the Service Locator. The reset method is asynchronous and cannot be…

Syrius: realtime graph not rendering a graph

OP correction. What? The realtime statistics are never calculated. Why? The realtime statistics are calculated on last week account blocks. Account blocks are retrieved by account block height. The momentum height is calculated using the frontier momentum height minus a fixed momentums per week constant of 60480. The calculated momentum height cannot be used to retrieve the last week account blocks and will always return an empty result. How? Page through the account blocks until the momen…

Syrius: Some proposals not displaying when "Only accepted" is toggled

OP correction. What? Incomplete results are given when filtering Accelerator Z projects without using a search term. Why? The bug only occures when no search term is used. When no search term is used, the getAll(pageIndex, pageSize) paging method is used. The paging variables are supplied by the infinite_scroll_bloc. The infinite_scroll_bloc uses a static pageSize of 10. Example: the getAll() method returns 10 projects, 6 of which are rejected or completed. The user applies the “Only Acce…

Syrius: bug fusing widget resets address field

OP correction. What? Under the plasma tab, where if you enter the beneficiary address, entering the amount resets the beneficiary address to the current selected address, and you need to change it again. Why? A widget’s state is stored in a State object, separating the widget’s state from its appearance. The state consists of values that can change, like a slider’s current value or whether a checkbox is checked. When the widget’s state changes, the state object calls setState(), telling the …

I’m open to discuss the work when needed.

[sol_sanctum]

I’m definitely considering these as well. My main concern is the amount of testing/review required.

I’ll ask the testers if they have the time to validate these.

[digitalSloth]

Hey @sol_sanctum and @CryptoFish great work on the PRs!

Just been testing them on a Mac and wanted to post feedback, some branches I’m unable to test due to the specific condition required to replicate the issue but if theres test accounts or ways to setup the wallet as required Im happy to test them as well.

---

Sol-Sanctum/disable_bridge - Much better with the form being removed completely, all works as expected.

KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.
KingGorrin/fix-rt-stats - Looks good, the graph loads both ZNN and QSR stats.
KingGorrin/fix-rt-yaxis - Not sure exactly what was broken but could not spot anything wrong.
KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.

---

I noticed two bits of visual distortion throughout all the branches

1st The copy/paste/select all popup alignment is messed up:

2nd the delegation stats widget, this only showed when Syrius is in a small window when i resized it it disappeared.

Final point, copy/paste keyboard shortcuts dont work on a Mac, this is also an issue with the current official release, not sure if its Mac specific or on other platforms as well.

[coinselor]

copy/paste/select all popup bug was addressed here:

Fix context menu

I also noticed it and checked his fix, works well:

---

Tested on Windows 10:

Sol-Sanctum/disable_bridge [ ]
KingGorrin/fix-fusing-addr-reset [ ]

[CryptoFish]

Thank you for testing .

@digitalSloth

2nd the delegation stats widget, this only showed when Syrius is in a small window when i resized it it disappeared.

There’s a fix for that one too, but both the ‘Fix context menu’ and ‘Fix RenderFlex overflow’ still depends on cicd branch. You can find it here.

Fix RenderFlex overflow

I don’t know exactly how you are testing, but seems like you’re using the build based on the cicd branch.

A better way of testing would be to isolate each and individual branch and build it from source. Using the official s y r i u s client as reference.

The cicd branch compounds a lot of changes which makes isolating the issue or feature hard.

I used the following procedure for testing my branches that are based on the Zenon_Network\master branch.

1. md Zenon_Nework
2. cd Zenon_Network
3. git clone GitHub - zenon-network/syrius
4. cd syrius
5. git remote add KingGorrin GitHub - KingGorrin/syrius
6. git pull KingGorrin $branch
7. flutter build $os
8. copy argon2_ffi_plugin.dll, libpow_links.dll, libznn.dll to .\build$OS\runner\Release
9. execute .\build$OS\runner\Release\syrius.exe
10. test and compare changes with the official client

Replace $branch with one of my branch names posted here and $os with linux, windows or macos based on your operating system.

You can copy the missing dll files from the official s y r i u s client. Also make sure you have flutter installed.

[digitalSloth]

Thanks for the links to those extra branches, just tested both and the issues have been resolved.

Iv been testing by checking out each of the feature branches and building a new copy of syrius for each one.