March PR Deadline

Just wanted to remind everyone of the March target for PR submissions. @aliencoder @sumamu @DrBlaze_21 we would love to jump on a Discord chat before the deadline to discuss your work and give the community an opportunity to ask questions. We can do them separately.


I’m hoping we can submit the Syrius PRs to:

  • disable the bridge
  • setup automatic releases (Github Actions / cicd)

I think @aliencoder is working on this?


The bug fixes which have been published to the forum can be submitted as seperate PR’s.

More details can be found on the forum under the following posts:

I’m open to discuss the work when needed.

1 Like

I’m definitely considering these as well. My main concern is the amount of testing/review required.

I’ll ask the testers if they have the time to validate these.

1 Like

Hey @sol_sanctum and @CryptoFish great work on the PRs!

Just been testing them on a Mac and wanted to post feedback, some branches I’m unable to test due to the specific condition required to replicate the issue but if theres test accounts or ways to setup the wallet as required Im happy to test them as well.

Sol-Sanctum/disable_bridge - Much better with the form being removed completely, all works as expected.

KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.
KingGorrin/fix-rt-stats - Looks good, the graph loads both ZNN and QSR stats.
KingGorrin/fix-rt-yaxis - Not sure exactly what was broken but could not spot anything wrong.
KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.

I noticed two bits of visual distortion throughout all the branches

1st The copy/paste/select all popup alignment is messed up:

2nd the delegation stats widget, this only showed when Syrius is in a small window when i resized it it disappeared.

Final point, copy/paste keyboard shortcuts dont work on a Mac, this is also an issue with the current official release, not sure if its Mac specific or on other platforms as well.

copy/paste/select all popup bug was addressed here:

I also noticed it and checked his fix, works well:

Tested on Windows 10:

Sol-Sanctum/disable_bridge [ :white_check_mark: ]
KingGorrin/fix-fusing-addr-reset [ :white_check_mark: ]

Thank you for testing .

There’s a fix for that one too, but both the ‘Fix context menu’ and ‘Fix RenderFlex overflow’ still depends on cicd branch. You can find it here.

I don’t know exactly how you are testing, but seems like you’re using the build based on the cicd branch.

A better way of testing would be to isolate each and individual branch and build it from source. Using the official s y r i u s client as reference.

The cicd branch compounds a lot of changes which makes isolating the issue or feature hard.

I used the following procedure for testing my branches that are based on the Zenon_Network\master branch.

  1. md Zenon_Nework
  2. cd Zenon_Network
  3. git clone GitHub - zenon-network/syrius
  4. cd syrius
  5. git remote add KingGorrin GitHub - KingGorrin/syrius
  6. git pull KingGorrin $branch
  7. flutter build $os
  8. copy argon2_ffi_plugin.dll, libpow_links.dll, libznn.dll to .\build$OS\runner\Release
  9. execute .\build$OS\runner\Release\syrius.exe
  10. test and compare changes with the official client

Replace $branch with one of my branch names posted here and $os with linux, windows or macos based on your operating system.

You can copy the missing dll files from the official s y r i u s client. Also make sure you have flutter installed.


Thanks for the links to those extra branches, just tested both and the issues have been resolved.

Iv been testing by checking out each of the feature branches and building a new copy of syrius for each one.