March PR Deadline

0x3639 · March 13, 2023, 11:52pm

Just wanted to remind everyone of the March target for PR submissions. @aliencoder @sumamu @DrBlaze_21 we would love to jump on a Discord chat before the deadline to discuss your work and give the community an opportunity to ask questions. We can do them separately.

https://twitter.com/Learn_Zenon/status/1635427336240742404?s=20

sol · March 14, 2023, 1:45am

I’m hoping we can submit the Syrius PRs to:

disable the bridge
setup automatic releases (Github Actions / cicd)

I think @aliencoder is working on this?

CryptoFish · March 14, 2023, 9:22am

The bug fixes which have been published to the forum can be submitted as seperate PR’s.

More details can be found on the forum under the following posts:

I’m open to discuss the work when needed.

sol · March 14, 2023, 12:52pm

I’m definitely considering these as well. My main concern is the amount of testing/review required.

I’ll ask the testers if they have the time to validate these.

digitalSloth · March 18, 2023, 7:14pm

Hey @sol and @CryptoFish great work on the PRs!

Just been testing them on a Mac and wanted to post feedback, some branches I’m unable to test due to the specific condition required to replicate the issue but if theres test accounts or ways to setup the wallet as required Im happy to test them as well.

Sol-Sanctum/disable_bridge - Much better with the form being removed completely, all works as expected.

KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.
KingGorrin/fix-rt-stats - Looks good, the graph loads both ZNN and QSR stats.
KingGorrin/fix-rt-yaxis - Not sure exactly what was broken but could not spot anything wrong.
KingGorrin/fix-fusing-addr-select - Works well, unable to replicate the original issue.

I noticed two bits of visual distortion throughout all the branches

1st The copy/paste/select all popup alignment is messed up:

2nd the delegation stats widget, this only showed when Syrius is in a small window when i resized it it disappeared.

Final point, copy/paste keyboard shortcuts dont work on a Mac, this is also an issue with the current official release, not sure if its Mac specific or on other platforms as well.

coinselor · March 19, 2023, 1:15am

copy/paste/select all popup bug was addressed here:

github.com/alienc0der/syrius

Fix context menu

alienc0der:cicd ← KingGorrin:fix-context-menu

opened 11:25AM - 01 Feb 23 UTC

KingGorrin

+22 -0

# Problem The right-click menu options should be in a row, not a column. #… Cause Syrius uses the default `contextMenuBuilder` for the TextFormField widgets. It controls the default copy/paste/cut/select all buttons for the platform. For example, under the Plasma tab when selecting the beneficiary address text and right clicking it. The context menu was horizontally orientated, but after using flutter 3.7.0 the buttons are now stacked vertically, showing black at both sides because the context menu is larger than the width of the buttons in it. Besides the change in the context menu, the selection handles when selecting text are not green anymore. # Solution I could not find a solution to change the orientation of the button items in the context menu, but did manage to style it accordingly by explicitly setting a `contextMenuBuilder` on the `InputField` widget. The context menu button items are now stacked vertically, using the complete width of the menu. The `selectionHandleColor` is added to the AppTheme. The property controls the handle color of the selection handles. More info on this can be found at: https://docs.flutter.dev/release/breaking-changes/text-selection-theme

I also noticed it and checked his fix, works well:

Tested on Windows 10:

Sol-Sanctum/disable_bridge [ ]
KingGorrin/fix-fusing-addr-reset [ ]

CryptoFish · March 19, 2023, 11:00am

Thank you for testing .

There’s a fix for that one too, but both the ‘Fix context menu’ and ‘Fix RenderFlex overflow’ still depends on cicd branch. You can find it here.

github.com/alienc0der/syrius

Fix RenderFlex overflow

alienc0der:cicd ← KingGorrin:fix-rf-overflow

opened 11:48AM - 27 Jan 23 UTC

KingGorrin

+55 -45

# Problem A RenderFlex overflowed exception is thrown in the card_scaffold an…d pillars_list_widget widgets when the application window is resized to its minimum allowed width/height. # Cause According to this [article ](https://docs.flutter.dev/testing/common-errors) the RenderFlex overflow is one of the most frequently encountered Flutter framework errors and usually occurs when a Column or Row has a child widget that is not constrained in its size. # Solution Contrain the unconstrained child widgets by wrapping them in an Expanded widget. # Things to know This PR only solves the widgets currently causing the exception. When Locales get implemented the issue might become apparent in other widgets because of varying string sizes.

I don’t know exactly how you are testing, but seems like you’re using the build based on the cicd branch.

A better way of testing would be to isolate each and individual branch and build it from source. Using the official s y r i u s client as reference.

The cicd branch compounds a lot of changes which makes isolating the issue or feature hard.

I used the following procedure for testing my branches that are based on the Zenon_Network\master branch.

md Zenon_Nework
cd Zenon_Network
git clone GitHub - zenon-network/syrius
cd syrius
git remote add KingGorrin GitHub - KingGorrin/syrius
git pull KingGorrin $branch
flutter build $os
copy argon2_ffi_plugin.dll, libpow_links.dll, libznn.dll to .\build$OS\runner\Release
execute .\build$OS\runner\Release\syrius.exe
test and compare changes with the official client

Replace $branch with one of my branch names posted here and $os with linux, windows or macos based on your operating system.

You can copy the missing dll files from the official s y r i u s client. Also make sure you have flutter installed.

digitalSloth · March 19, 2023, 4:45pm

Thanks for the links to those extra branches, just tested both and the issues have been resolved.

Iv been testing by checking out each of the feature branches and building a new copy of syrius for each one.