Github Actions for NoM repos

šŸ’» ā”‚ Development
,
41

Awesome. I will test on Mac M1 and Linux tomorrow.

1 Like
42

Iā€™m not sure how multi-address is supposed to work.

The widget displays a list of all generated addresses but it seems you were trying to display a subset of the addresses?
I didnā€™t understand the meaning of the # of 10 indicator at the bottom, since iterating from 1 to 10 doesnā€™t really change the widget.
When I reached 11, the widget re-loaded and created 10 new addresses for me?

Edit: Obviously, I didnā€™t understand what the 1 of 10 meant. If a user wants to add 6 addresses, they increment to 6 then press Add addresses. Is this clear to everyone else?
The + sign can still be pressed/activated when the user reaches 10, maybe thatā€™s intended?

Maybe we need to have the integer in the ā€œAdd addressesā€ button, such that it clearly tells the user they are about to ā€œAdd 6 addressesā€.

43

Iā€™ve tested the Windows and Linux releases.
Both work as expected, though I still encountered an issue with Linux.

Display Driver Error

I had forgotten about this issue, but the Linux Release build crashes often since Iā€™m using nouveau display drivers instead of nvidia.
Error: syrius: ../nouveau/pushbuf.c:730: nouveau_pushbuf_data: Assertion `kref' failed.
If it impacts enough users, Iā€™ll try to find a workaround, though I may not be successful.

Despite all that, the Debug version of the app runs well-ish (it stutters a bit) while the Release build is snappy.

Iā€™ve made several changes to the cicd branch and will submit a PR with a detailed summary after some MacOS testing with 0x.

44

I just setup on a clean Ubuntu 22.04 VM and have 2 errors.

(syrius:4410): Gtk-WARNING **: 07:21:29.297: Error loading icon from file 'linux/resources/app_icon.png':
	Failed to open file ā€œlinux/resources/app_icon.pngā€: No such file or directory
Starting znnd.
current time is 2022-12-30 07:21:33
version: v0.0.4-libznn
git-commit-hash: 7e9c440f7e5e368efbade77ca900efa1219af0d4
znnd will use at most 4 cpu-cores
WARN[12-30|07:21:33] Config file missing: you can provide a data path using the --data flag or provide a config file using the --config flag module=zenon configPath=/home/x3639/.znn/config.json

And when I try to create a json export of the keyfile, I get this error.

[ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: [FileSystemException: Directory listing failed, path = '/home/x3639/.pub-cache/' (OS Error: No such file or directory, errno = 2), #0      _Directory._fillWithDirectoryListing (dart:io-patch/directory_patch.dart:42)
#1      _Directory.listSync (dart:io/directory_impl.dart:243)
#2      initArgon2.<anonymous closure> (package:znn_sdk_dart/src/argon2/argon2.dart:30)
#3      Argon2FfiFlutter._loadLib (package:argon2_ffi_base/src/argon2_ffi_impl.dart:160)
#4      new Argon2FfiFlutter (package:argon2_ffi_base/src/argon2_ffi_impl.dart:92)
#5      initArgon2 (package:znn_sdk_dart/src/argon2/argon2.dart:15)
#6      KeyFile._encryptEntropy (package:znn_sdk_dart/src/wallet/keyfile.dart:95)
<asynchronous suspension>
#7      saveKeyStoreFunction (package:znn_sdk_dart/src/wallet/manager.dart:22)
<asynchronous suspension>
]
#0      KeyStoreManager.saveKeyStore.<anonymous closure> (package:znn_sdk_dart/src/wallet/manager.dart:54)
#1      _RootZone.runUnaryGuarded (dart:async/zone.dart:1586)
#2      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339)
#3      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271)
#4      _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:774)
#5      _StreamController._add (dart:async/stream_controller.dart:648)
#6      _StreamController.add (dart:async/stream_controller.dart:596)
#7      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192)

This is how to recreate the error. I was able to replicate it as sudo also.

1 Like
45

I see two warnings:

  1. failed to open a .png file
  2. config file missing

For #1, Iā€™ve opted to remove that check until we have a proper mechanism to display the icon. My repo also has Github Actions so you may try the build here.

I donā€™t believe #2 is an issue; the wallet experience recovers gracefully when the config file is not initially present.

As for the KeyStore issue, Iā€™ve submitted a PR to aliencoderā€™s znn_sdk_dart repo.

1 Like
46

Just wanted to let you know that I tried to install the new release on my Mac M1 and experienced the same issue with not being able to export the .json key. I stopped testing at that point.

47

@0x3639 Iā€™ll check everything youā€™ve reported again and try to fix all the issues.

@sol_sanctum I responded to your PR on Github. I think itā€™s better to verify if the .pub-cache directory exists instead of throwing an error.

1 Like
48

Iā€™ve added the fix.

1 Like
49

The problem with the missing icon on Linux is that it doesnā€™t find it at this path linux/resources/app_icon.png. Iā€™ll try to fix it by using a relative path.

50

I opted to remove the configuration until we have a proper .desktop file in place.
I donā€™t think weā€™ll be able to devise a universal Linux solution without package management, though we may be able to fix the window icon, as per this post.

The main reasons for this:

  1. ELF files donā€™t natively support icons
  2. .desktop files donā€™t typically support relative paths
51

Unfortunately that post doesnā€™t work, neither this one.

The only way to get it showing properly is to have a dynamic reference to the assetā€™s directory at runtime.

Also I think by properly packaging the app weā€™ll be able to solve the issue without using the gtk_window_set_icon method.

52

Tried to use this library to create DMG exe and deb, but without success.

1 Like
53

Took a look at the workflow file. I think we will want to add testing before creating a release.

2 Likes
54

Do you mean QA testing, code coverage or both?

Iā€™ve noticed that some Zenon releases have also an additional alpha tag appended - we can do the same.

55

We can use this action for syrius and znn_sdk_dart.

For go-zenon Iā€™ve added govulncheck-action, but now itā€™s (Commented out govulncheck Ā· zenon-network/go-zenon@344e080 Ā· GitHub).

1 Like
56

The codebase has unit tests and weā€™ll probably want to continue to add tests. I just wouldnā€™t want to create downloaded releases through a pipeline unless the pipeline included running tests.

1 Like
57

I agree, Iā€™ll add unit-testing. Do you see something else worth integrating into the pipeline? I want to finish the cicd pipeline and open PRs as soon as possible.

58

Fixed unit-tests and added version command in the Makefile. Take a look.

59

Update: abort when a test fails and automatically set a version for the release.

1 Like
60

Added action status badges in the README and updated syrius_library_updater such that it wonā€™t fail if changes are not present.

1 Like